You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Gbasis assumes for each set of contraction primitives, contraction coefficients do not include $N(\alpha_i, \mathbf{a})$. There could be packages though where generated basis sets already include primitive normalization constants in the contraction coefficients for each primitive as shown in #194 . This issue suggests an enhancement to Gbasis code to allow for basis sets with primitive normalization constants already included in the contraction coefficients.
Is there a specific integral/formula that you would like implemented?
Is there a change to the code or algorithm you would like to see?
The normalization constant for each cartesian primitive is calculated at the contractions module in norm_prim_cart. Primitive normalization is used for all the integrals and density evaluations usually when the a lower level function is called. In the case of overlap for example when the Overlap class calls _compute_multipole_moment_integrals in construct_array_contraction the norm_prim_cart information is passed. There would be two ways to include this option into Gbasis.
As an argument to contractions and can be specified also when using parsers or wrappers. Then internally norm_prim_cart could read that flag and generate ones instead of the normalization constants
As an argument to the methods they use the normalization constants (most of them).
Additional info: Gbasis works at the low level only with cartesian primitives. Spherical primitives are converted to Cartesian here in generate_transformation. There the normalization applied is a factor combining Cartesian and Spherical normalizations:
generate_transformation uses the last simplification here but I think we could refactor that part to only use the spherical normalization if the contraction coefficients already include the cartesian primitive normalization.
Additional context
The text was updated successfully, but these errors were encountered:
I like the idea of handling this as a preprocessing step (parser/wrapper level). Just a pre-processor-function that just converts any user-specified basis set to a gbasis-format basis set by "undoing" the primitive normalization and adjusting the contraction coefficients accordingly. We have to expect that the user knows what convention the given basis set uses because, if they do not, then there is no (robust and general) way to detect it.
Is your feature request related to a problem? Please describe.
Currently Gbasis works with Cartesian primitives defined as:
Where$N(\alpha_i, \mathbf{a})$ is the normalization constant of the Cartesian primitive defined as:
Gbasis assumes for each set of contraction primitives, contraction coefficients do not include$N(\alpha_i, \mathbf{a})$ . There could be packages though where generated basis sets already include primitive normalization constants in the contraction coefficients for each primitive as shown in #194 . This issue suggests an enhancement to Gbasis code to allow for basis sets with primitive normalization constants already included in the contraction coefficients.
Is there a specific integral/formula that you would like implemented?
Is there a change to the code or algorithm you would like to see?
The normalization constant for each cartesian primitive is calculated at the contractions module in norm_prim_cart. Primitive normalization is used for all the integrals and density evaluations usually when the a lower level function is called. In the case of overlap for example when the Overlap class calls
_compute_multipole_moment_integrals
in construct_array_contraction thenorm_prim_cart
information is passed. There would be two ways to include this option into Gbasis.norm_prim_cart
could read that flag and generate ones instead of the normalization constantsAdditional info: Gbasis works at the low level only with cartesian primitives. Spherical primitives are converted to Cartesian here in
generate_transformation
. There the normalization applied is a factor combining Cartesian and Spherical normalizations:generate_transformation
uses the last simplification here but I think we could refactor that part to only use the spherical normalization if the contraction coefficients already include the cartesian primitive normalization.Additional context
The text was updated successfully, but these errors were encountered: