You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some of you may have noticed that I have been actively working on our package. I have fixed some problems. If you have seen my code reviews, that means that you can start working with your part again. You will need to address the problems before we merge your PR.
Also, it's important to update your local git repo. Here is how,
# suppose you are in your main branch# add theochem as your upstread repo
git remote add [email protected]:theochem/DiverseSelector.git
# update your local main branch
git pull theochem main
# update your remote main branch in GitHub
git push origin main
# check out your working branch
git check your_branch_name
git rebase main
# update your_branch_name in GitHub
git push origin your_branch_name
# now you can start working
Maybe better to follow good practices of writing codes.
Write clean commit message with smaller code changes
Run tox to make sure things work well before your add your changes to git or push to GitHub
Break down a big pull request with many many commits into several smaller PR is good and nice for code review
Write complete and clean documentation following numpy docstrings style
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Some of you may have noticed that I have been actively working on our package. I have fixed some problems. If you have seen my code reviews, that means that you can start working with your part again. You will need to address the problems before we merge your PR.
Also, it's important to update your local git repo. Here is how,
Maybe better to follow good practices of writing codes.
tox
to make sure things work well before your add your changes to git or push to GitHubnumpy
docstrings styleHere are some resources that might be of help,
Thank you for making this project moving! Next time, probably we can have everyone as a code reviewer.
@alanqf22 @RichRick1 @Khaleeh
Beta Was this translation helpful? Give feedback.
All reactions