Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] useAddress in Account Manager uses JS SDK #111

Closed
zinoadidi opened this issue Apr 1, 2021 · 5 comments
Closed

[Task] useAddress in Account Manager uses JS SDK #111

zinoadidi opened this issue Apr 1, 2021 · 5 comments
Labels
third-party tasks outside tnb-js sdk

Comments

@zinoadidi
Copy link
Contributor

Task

Contributors are able to complete this task and earn thenewboston coins. Check out the labels to learn how much you can earn for contributing by completing this task. Please make sure to be honest if you wish to contribute by saying you can't finish this and we can just un-assign you with no harm done! There is no point in delaying tasks from being completed for miscommunication!

Overview

generateAccount function in Account manager uses JS SDK

All missing functionalities that hinder the implementation are reported and resolved on the SDK side
Use the SDK documentation
Undocumented processes and wrong information in doc should be corrected
Resolves thenewboston-blockchain/Account-Manager#585

Behavior

Account manager uses js sdk installed from NPM https://www.npmjs.com/package/thenewboston
useAddress function in Account manager uses JS SDK

Please ask for this task to be assigned to you and earn and its sweet reward 😉

Remember to include your account number in your PR description for us to pay you 💰

** Pull Requests **
All Pull Request should be made to development branch, read contributors guild for more information about contributing

@zinoadidi
Copy link
Contributor Author

@tomijaga how about this one

@zinoadidi
Copy link
Contributor Author

@tomijaga can you make a PR from the sdk branch to master and tag justin / me on it;
don't want to claim your fixes :)

@tomijaga
Copy link
Contributor

tomijaga commented Apr 12, 2021

Sure @zinoadidi I will do that in a bit

@tomijaga
Copy link
Contributor

tomijaga commented Apr 12, 2021

@zinoadidi
This was also an error. It had nothing to do with the api.

@zinoadidi
Copy link
Contributor Author

not implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
third-party tasks outside tnb-js sdk
Projects
None yet
Development

No branches or pull requests

2 participants