Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include patterns as resource, and load by default #63

Open
OrangeDog opened this issue Mar 6, 2017 · 1 comment
Open

Include patterns as resource, and load by default #63

OrangeDog opened this issue Mar 6, 2017 · 1 comment

Comments

@OrangeDog
Copy link

OrangeDog commented Mar 6, 2017 •
edited
Loading

  1. Move /patterns to /src/main/resources/io/thekraken/grok/patterns (or similar).
  2. Add create(InputStream) and/or create(URL) methods to allow loading patterns from not just files.
  3. Add a create() method that loads all the packaged patterns.
@OrangeDog
Copy link
Author

For some reason I hadn't noticed addPatternFromReader.
The priorities are therefore 1, 3, 2 I suppose.

@OrangeDog OrangeDog changed the title Include patterns as resource directory, and allow loading from resource Include patterns as resource, and load by default Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OrangeDog