-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare method does not warn about unknown parameters #596
Comments
Hi Marius, Thanks for opening this issue. I think we should discuss whether we want to throw an error for unrecognized arguments. We do this in the In @michalk8 , do you have an opinion on this? |
we discussed this extensively in the past and I still think it's a pretty bad and unique ux design, wrong arguments should always errors, I understand that we had other priorities but it's something we'll have to figure out sooner than later |
closed with #696 |
amazing, this is great! I think this was very important and will prevent many future mistakes in practical applications. |
I was just wondering why
problem.prepare
recomputes a PCA, even though I pre-computed one and passedjoin_attr='X_pca'
until I realized that I had a typo in there. Theprepare
method does not complain about this, which can lead to unexpected behaviour.The text was updated successfully, but these errors were encountered: