Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Survival Analysis Estimators consistent, and pass all required arguments #822

Open
eroell opened this issue Nov 7, 2024 · 2 comments · May be fixed by #825
Open

Make Survival Analysis Estimators consistent, and pass all required arguments #822

eroell opened this issue Nov 7, 2024 · 2 comments · May be fixed by #825
Assignees
Labels
enhancement New feature or request

Comments

@eroell
Copy link
Collaborator

eroell commented Nov 7, 2024

Description of feature

  1. consistency
    E.g. tl.kmf operates on two arrays (see also Think about easier interface for KMF #387) while tl.nelson_aalen operates on an anndata.
    The latter should be the norm here if suitable.
  2. passing all required arguments
    Then, e.g. tl.weibull doesnt take the entry column or any way to pass this to the fitter; harmonizing this to ensure all flexibility offered by lifelines is userfacing would be a great enhancement!
@eroell eroell added the enhancement New feature or request label Nov 7, 2024
@eroell
Copy link
Collaborator Author

eroell commented Nov 7, 2024

Can also make a suitable checkpoint list here together if it helps!

@aGuyLearning
Copy link
Collaborator

aGuyLearning commented Nov 13, 2024

  • Update Readme in Notebooks to include an installation command for locally cloned repos
  • make method signatures uniform and kwargs
  • update notebook example using kmf
  • update documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants