Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make download part of ehrdata #817

Open
eroell opened this issue Nov 6, 2024 · 2 comments
Open

Make download part of ehrdata #817

eroell opened this issue Nov 6, 2024 · 2 comments
Assignees
@eroell
Labels
enhancement New feature or request

Comments

@eroell
Copy link
Collaborator

eroell commented Nov 6, 2024

Description of feature

The _dataloader module is currently private. Should we make it be part of the public API? It is useful for downloading datasets, and could also be so for other developers.

The least reduces redundancy for us, without us using private modules across repos

ehrapy/ehrapy/data/_dataloader.py

Line 17 in 0a74f70

def download(

@eroell eroell added the enhancement New feature or request label Nov 6, 2024
@Zethson
Copy link
Member

Zethson commented Nov 6, 2024

I could see it become a part of ehrdata and ehrapy depend on ehrdata. WDYT?

@eroell
Copy link
Collaborator Author

eroell commented Nov 6, 2024

Sounds good to me 👍

@eroell eroell changed the title Make download part of public API? Make download part of ehrdata Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eroell eroell

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zethson @eroell