Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validating encoded-ness state of AnnData object #815

Open
eroell opened this issue Oct 31, 2024 · 0 comments
Open

Validating encoded-ness state of AnnData object #815

eroell opened this issue Oct 31, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@eroell
Copy link
Collaborator

eroell commented Oct 31, 2024

Description of feature

This is not an ideal way of checking whether the adata has been encoded:

assert np.issubdtype(adata.X.dtype, np.number)

as we do not guarantee that ep.pp.encode will enforce this typing of the array.

Think about whether to

  • use a tag instead, e.g. stored in .uns
  • be more clear on the dtype .X is allowed to have.

The latter option might be more clean, and could be considered a subissue of consistent use with infer feature type and

@eroell eroell added the enhancement New feature or request label Oct 31, 2024
@eroell eroell self-assigned this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant