✨Allow importing modules as raw YAML #80
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #79 for context
Approach
This implements the
$import { location: string, quote: true }
syntax described in the above issue. To do it, a new value typePSQuote
is introduce which can contain any otherPSValue
. APSQuote
evaluates to the value it quotes. In this way it "shields" the value from evaluation, so rather than traversing the tree to evaluate it, the tree itself is returned.When an import is marked as
quote
, the resulting module value is quoted.Alternate Designs
For marking quotes:
quoted
property to everyPSValue
rather than decorating it. I decided against this for two reasons:if
statements everywhere to find out if this was a quoted string or a unquoted string.For marking that an import is to be quoted:
I wasn't super thrilled about map specifier for modules:
But a better alternative that didn't bring in more complexity did not present itself. We may want to use tags in some form or another later on and deprecate this syntax.