Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten foreman manual #2076

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

maximiliankolb
Copy link
Contributor

I've made two commits to shorten the Foreman Manual in favor of docs.theforeman.org.

  • How do you like this approach?
  • Should we exclusively link to build target "foreman" or is "katello" OK/better?
  • Should I "replicate" my changes to any released versions?

I am really unsure if this is in the spirit of https://community.theforeman.org/t/making-docs-theforeman-org-the-primary-documentation-source/32657.

cc @adamlazik1

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is roughly the idea that I have for this, but keeping the anchors is important. It's why the chef section is still there, but empty. Otherwise all anchors would change.

As well as all users who helped test releases, report bugs and provide feedback on the project.
* [Foreman {{page.version}} on EL](https://docs.theforeman.org/{{page.version}}/Release_Notes/index-foreman-el.html)
* [Foreman {{page.version}} on Debian/Ubuntu](https://docs.theforeman.org/{{page.version}}/Release_Notes/index-foreman-deb.html)
* [Foreman {{page.version}} with Katello Release Notes](https://docs.theforeman.org/{{page.version}}/Release_Notes/index-katello.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit unsure about this: we don't really have anything Katello in this manual.

Comment on lines -85 to -94
### 4.2.1 Environments
{%include manuals/{{ page.version }}/4.2.1_puppet_envs.md %}
### 4.2.2 Classes
{%include manuals/{{ page.version }}/4.2.2_puppet_classes.md %}
### 4.2.3 Parameters
{%include manuals/{{ page.version }}/4.2.3_puppet_params.md %}
### 4.2.4 Parameterized Classes
{%include manuals/{{ page.version }}/4.2.4_param_classes.md %}
### 4.2.5 Smart Matchers
{%include manuals/{{ page.version }}/4.2.5_matchers.md %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These anchors are linked from within the foreman_puppet plugin:

$ rg '4\.2\.' app/ webpack/
app/views/foreman_puppet/puppetclasses/_form.html.erb
38:            <%= documentation_button('4.2.5ParameterizedClasses') %>

app/views/foreman_puppet/puppetclasses/index.html.erb
4:                 documentation_button('4.2.2Classes') %>

app/views/foreman_puppet/puppetclass_lookup_keys/welcome.html.erb
10:                                    :documentation => { :url => documentation_url("4.2.5ParameterizedClasses") },

app/views/foreman_puppet/puppetclass_lookup_keys/index.html.erb
2:<% title_actions documentation_button('4.2.5ParameterizedClasses') %>

webpack/src/Components/Environments/Welcome.js
15:    '4.2.2Classes'
23:      documentation={{ url: getManualURL('4.2.1Environments') }}

So please keep all chapters until there are replacements.

And now that I see this, it looks like there's also a bug where 4.2.5 became 4.2.4. That was a while back, so I wonder how many people actually use the functionality.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I should rather open a PR against foreman/foreman_puppet nightly to accompany this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today there is no way to link to the new docs, that's what https://community.theforeman.org/t/making-docs-theforeman-org-the-primary-documentation-source/32657#moving-over-foreman-itself-4 is about: introducing the API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants