Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to katello-host-tools 4.4.0 #10765

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

sbernhard
Copy link

@sbernhard sbernhard force-pushed the bump_katello_host_tools branch 7 times, most recently from 78dfb99 to 22f732d Compare May 10, 2024 11:16
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had a look at the generated RPMs yet to see what they actually package.

@evgeni
Copy link
Member

evgeni commented May 17, 2024

  • katello-host-tools contains /usr/lib/python*/site-packages/katello/tracer/__pycache__, this seems wrong :) (but not a problem from DNF perspective, as it's a folder)
  • katello-host-tools-tracer.el7 contains /usr/lib/python2.7/site-packages/katello/tracer/dnf.py but there is no DNF on el7 (by default). If I read https://github.com/Katello/katello-host-tools/blob/37c7fdfe0b9fdfb794174415098d45b46aac3c71/src/katello/tracer/__init__.py#L9-L21 this will "do the right thing" (and fallback to original tracer), but I wonder if it's a good idea to differ depending on "user did install dnf on el7 or not"
  • katello-host-tools-tracer.el7 has no dependency on python2-tracer anymore, so the above will actually not work
  • no idea about the suse builds, we don't build them :/

@evgeni
Copy link
Member

evgeni commented May 17, 2024

I've opened #10804 so that we at least try building suse 15.5

@m-bucher m-bucher force-pushed the bump_katello_host_tools branch 3 times, most recently from 3db4324 to 1a3dbf1 Compare May 17, 2024 12:32
@evgeni
Copy link
Member

evgeni commented May 22, 2024

#10804 was merged, so feel free to rebase and see what happens :)

@evgeni
Copy link
Member

evgeni commented May 22, 2024

Yay, repoclosure failures. I'll see if we can fix those.

@sbernhard
Copy link
Author

Yay, repoclosure failures. I'll see if we can fix those.

maybe you want to use the build dependencies from https://oss.atix.de/html/sles.html

@evgeni
Copy link
Member

evgeni commented May 22, 2024

@evgeni
Copy link
Member

evgeni commented May 22, 2024

[test rpm-copr]

@evgeni
Copy link
Member

evgeni commented Jun 12, 2024

Three tiny things:

  • the psutil dep should be in the tracer subpackage (that's the only thing I'd expect to be fixed to merge this, the rest is cosmetics)
  • the suse and el7 tracer packages end up having tracer/SystemdDbus.py, which doesn't hurt but also is unused there
  • the k-h-t package on el8 and el9 contain /usr/lib/python*/site-packages/katello/tracer/ directory (empty), again, doesn't hurt but seems odd.

@evgeni evgeni merged commit 626307d into theforeman:rpm/develop Jun 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants