Use system Puppet in CI #942
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ekohl
force-pushed
the
use-system-puppet-in-ci
branch
3 times, most recently
from
5e1c964
to
926140f
Compare
This uses the official Puppet AIO packages, which is also what we use in production. This makes the tests more realistic.
ekohl
force-pushed
the
use-system-puppet-in-ci
branch
from
926140f
to
8ee2f91
Compare
evgeni
reviewed
May 8, 2024
| run: | | ||
| . /etc/os-release | ||
| wget "https://apt.puppet.com/puppet${{ matrix.puppet }}-release-${VERSION_CODENAME}.deb" | ||
| sudo apt install "${PWD}/puppet${{ matrix.puppet }}-release-${VERSION_CODENAME}.deb" |
There was a problem hiding this comment.
You need to do ./puppet...., apt refuses local installs from things that don't look like paths
There was a problem hiding this comment.
That's why I added ${PWD}. I guess ./ would have also worked.
There was a problem hiding this comment.
ah yes, the race between typing a comment on mobile and forgetting to hit send and you pushing more changes :)
|
I think librarian isn't friendly with the AIO Puppet: |
|
As I wrote somewhere else: I'm leaning to adding a step that builds the modules as separate from the others. Then store it in a cache and reuse it in the other axes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the official Puppet AIO packages, which is also what we use in production. This makes the tests more realistic.
Currently just testing out if this even works.