Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UIManager for undo/redo of crop/delete/insert #9

Open
theerfan opened this issue Feb 5, 2024 · 2 comments
Open

Use UIManager for undo/redo of crop/delete/insert #9

theerfan opened this issue Feb 5, 2024 · 2 comments

Comments

@theerfan
Copy link
Owner

theerfan commented Feb 5, 2024

Without that, they'll get mixed up and it'll keep making new pdfs. We don't want that.

@theerfan
Copy link
Owner Author

The cmd command works now, but the undo doesn't. [For our new classes, PageOrganizer and Crop]
Need to look at the trace to see where the undo command doesn't get added.

@theerfan
Copy link
Owner Author

Also, as we're trying to keep the annotations on insert/delete page commands using the setAll function, note that the annotation does get moved but is invisible, and the number of pages on which the annotation gets put on doesn't get adjusted.

So:

  1. Look up how pdf.js shows the elements relating to those annotations and make them visible/create them again
  2. Try to change the objects you get from the getAll method to adjust for the pages/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant