Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatePickerRenderer should be improved #13

Open
moufmouf opened this issue Jan 9, 2014 · 0 comments
Open

DatePickerRenderer should be improved #13

moufmouf opened this issue Jan 9, 2014 · 0 comments

Comments

@moufmouf
Copy link
Member

moufmouf commented Jan 9, 2014

The DatePickerRenderer has a public property "settings" so far that is a string that must be the JSON parameters. This is really not the best we can do.

We should at least:

  • stop using public properties: use constructor parameters or setters instead
  • make sure the most common parameters are exposed directly. For instance, we should have a "setDateFormat" method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moufmouf