Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python2 likely no longer needed #98

Open
amedeedaboville opened this issue Mar 10, 2020 · 0 comments
Open

Python2 likely no longer needed #98

amedeedaboville opened this issue Mar 10, 2020 · 0 comments

Comments

@amedeedaboville
Copy link

Description

The README mentions that python2 is required because of the better-sqlite3 package.
It itself requires python2 because it depends on node-gyp, but recent versions of node-gyp support python3 and don't require python2.

The user may need to do
npm i -g node-gyp@latest
(see WiseLibs/better-sqlite3#345)
And we may need to update better-sqlite3 to version 6.0.1.
(WiseLibs/better-sqlite3#310 (comment))

Reading the commit log (they don't seem to have a changelog?) It doesn't look like anything has broken between better-sqlite3 version 5.4.0 as is currently in package.json vs 6.0.1.
I will run the tests with 6.0.1, and maybe will try installing this in a docker?

Expected result

Python2 should no longer be required to install rc-coffee-chats.

Actual result

Python2 is still required to to install rc-coffee-chats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant