Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Current State of the Mod #197

Open
thecatcore opened this issue May 3, 2022 · 2 comments
Open

Current State of the Mod #197

thecatcore opened this issue May 3, 2022 · 2 comments
Labels
bug Something isn't working compatibility dependencies Pull requests that update a dependency file enhancement New feature or request help wanted Extra attention is needed

Comments

@thecatcore
Copy link
Owner

thecatcore commented May 3, 2022

I think most people looking at the github here have remarked that I'm really not that active anymore on the project.
It's mostly because of a lack of motivation, but also because the development of the mod isn't easy with the current project setup.

Most important issues with the current project setup and the current code base:

  • It's not possible to test the mod in dev.
  • The code isn't documented much, making it hard for other devs to contribute and fix bugs.
  • The mod use sub-mods/jar-in-jar to support multiple versions with one big jar file however, each sub-mod is loaded at least a tiny bit in production. More recent versions of Fabric Loader allow sub-mods to not load at all without crashing the game if their depencencies are not met.
  • A better documentation for users about the mod config needs to be written.
  • The mod is incompatible with most mods doing modifications to text format.
  • There is an issue related to the discord library used. It depends on the slf4j logging library which is included by Minecraft 1.17+ but not earlier. So if I include it, it crashes on new versions because the library is loaded 2 times, but it's necessary to include it for older versions for the mod to run at all.
  • The mod broke with 1.19 snapshots, some work needs to be done to support it before it releases.

There are more issues, but I need help to fix at least those mentioned here.

I also want to thank first every person who contributed to the project and second to every person who has downloaded this mod as well as has reported bugs.

@thecatcore thecatcore added the enhancement New feature or request label May 3, 2022
@thecatcore thecatcore pinned this issue May 3, 2022
@thecatcore thecatcore added bug Something isn't working help wanted Extra attention is needed dependencies Pull requests that update a dependency file compatibility labels May 3, 2022
@srnyx
Copy link

srnyx commented Jun 7, 2022

Maybe add some sort of statistics thing to collect data about how many people actually use the older versions. I don't feel like versions such as 1.6.4 and 1.17.10 need to be supported at all. If no one uses the older versions, you don't need to support them. Just only continue work on the ones that people actually use. That should solve 2 of your issues (unless a lot of people use every version lmao).

@thecatcore
Copy link
Owner Author

👀
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working compatibility dependencies Pull requests that update a dependency file enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants