From d65dc7ac77fb05d1bfd148f793028101fbcc7f79 Mon Sep 17 00:00:00 2001 From: Suyash Srijan Date: Wed, 12 Jun 2019 16:08:03 +0100 Subject: [PATCH 1/2] [Project] Add quotes to generated hashes in the array example in the README --- README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index b3743da..7a329b0 100644 --- a/README.md +++ b/README.md @@ -134,7 +134,7 @@ You have to make the type in your plist a string, and input either a number -- e # Arrays -Configen also supports reading arrays from the plist. For example, you can create an array of certificate hashes for pinning purposes and then in the mapping file, declare the configuration variable as something like `arrayOfHashes: [String]` and configen will automatically generate an array for you. +Configen also supports reading arrays from the plist. For example, you can create an array of certificate hashes for pinning purposes and in the mapping file, declare the configuration variable as something like `arrayOfHashes: [String]` and then configen will automatically generate an array for you. The downside of using arrays in plist is that the order of the array and whether there are any array elements at all are not guaranteed, so keep that in mind when using this functionality. @@ -165,8 +165,8 @@ Example: ``` static let arrayOfHashes: [String] = [ - 9BV3692736V893B47V893BY4V94B8V6123984BV6983V6B093, - BVQ09PY89V86BY98VY9876BV9786B98687B6976BOP967BP96, - PB869869P6B76P9B7869P8B69P697P69769769P7B697PB89B + "9BV3692736V893B47V893BY4V94B8V6123984BV6983V6B093", + "BVQ09PY89V86BY98VY9876BV9786B98687B6976BOP967BP96", + "PB869869P6B76P9B7869P8B69P697P69769769P7B697PB89B" ] ``` From 9c5d1309b0dd7ad7568427490baa3c184805e2c4 Mon Sep 17 00:00:00 2001 From: Suyash Srijan Date: Wed, 12 Jun 2019 16:14:03 +0100 Subject: [PATCH 2/2] [Project] Update the arrays section in the README This is just changing the language a bit --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 7a329b0..e842915 100644 --- a/README.md +++ b/README.md @@ -134,9 +134,9 @@ You have to make the type in your plist a string, and input either a number -- e # Arrays -Configen also supports reading arrays from the plist. For example, you can create an array of certificate hashes for pinning purposes and in the mapping file, declare the configuration variable as something like `arrayOfHashes: [String]` and then configen will automatically generate an array for you. +Configen also supports reading arrays from the plist. For example, you can create an array of certificate hashes for pinning purposes and configen will automatically map them to an array in the generated configuration file. -The downside of using arrays in plist is that the order of the array and whether there are any array elements at all are not guaranteed, so keep that in mind when using this functionality. +The downside of using an array in the plist is that the order of the array and whether there are any array elements at all is not guaranteed, so keep that in mind when using this functionality. Example: