Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete or update semantic entries #9

Open
javiertoledo opened this issue Jul 25, 2023 · 2 comments
Open

Delete or update semantic entries #9

javiertoledo opened this issue Jul 25, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@javiertoledo
Copy link
Member

With the current implementation, it's possible to use the learn method in the SemanticSearch component to generate a SemanticEntry in our vector store, but we don't have a way to delete or update them.

I'd propose to add update and delete, or maybe a forget method to remove a semantic entry from the database.

@javiertoledo javiertoledo added the good first issue Good for newcomers label Jul 25, 2023
@NickSeagull
Copy link
Member

I envision this as two different methods deleteWithId and forget.

The first one deletes the one with the specified ID, while the other one deletes the closest one semantically to that phrase.

I don't know if that makes sense.

@javiertoledo
Copy link
Member Author

I'd only allow deleting with id. A method that deletes "The semantically closest record" could have quite unpredictable results 😅

@juanjoman juanjoman transferred this issue from theam/eLLMental-kt Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants