New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bring back pytype static checking #8

Open

charlesfrye opened this issue Jul 7, 2022 · 0 comments

Collaborator

charlesfrye commented Jul 7, 2022

it is no longer in the requirements, isn't in the linting, and doesn't run on 2022 branch at https://github.com/full-stack-deep-learning/fsdl-text-recognizer-2021/commit/0e875130ac429c68e1188a43ebe68045dafb4116

Process:
add to pre-commit
lint all files
add to dev-lint environment
run locally
add to tasks/lint.sh

to consider: it is very slow -- probably adds another two or three minutes to run it on the entire codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment