Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newtype deriving strategy for Show #32

Open
the-dr-lazy opened this issue Feb 22, 2021 · 0 comments
Open

Newtype deriving strategy for Show #32

the-dr-lazy opened this issue Feb 22, 2021 · 0 comments
Labels
Priority: Critical Scope: cascade-api Status: Available Type: Bug
Milestone
v0.1.0

Comments

@the-dr-lazy
Copy link
Owner

Description

Username, EmailAddress, and Password types use newtype deriving strategy for Show instances. This was not intentional and is wrong in this case.

cascade/cascade-api/src/Cascade/Api/Data/Text/Username.hs

Line 34 in 32f5991

deriving newtype (Show, Eq, FromJSON, ToJSON)

cascade/cascade-api/src/Cascade/Api/Data/Text/EmailAddress.hs

Line 29 in 32f5991

deriving newtype (Show, Eq, FromJSON, ToJSON)

cascade/cascade-api/src/Cascade/Api/Data/ByteString/Password.hs

Line 31 in 32f5991

deriving newtype (Show, Eq)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Critical Scope: cascade-api Status: Available Type: Bug
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
1 participant
@the-dr-lazy