Conditional compilation issues

[Alekcvp]

There are issues with conditional defines in source files, leading to the strange things after the compilation:

For ex:
uiblib.pas(128): {$IFDEF FB21_UP}
uiblib.pas(144): {$IFNDEF FB_21UP}

[the-Arioch]

what exactly "unusable" mean ?

what is FB version and testcase ?

[Alekcvp]

Answered in #2.

[the-Arioch]

Line 128 is about charsets, not transactions.

Perhaps FB 2.1 added special requirements about those options, that woked in FB 2.0 and before

  isc_tpb_shared,
  isc_tpb_protected,
  isc_tpb_exclusive,

[Alekcvp]

Line 128 is about charsets, not transactions.

I mean: compare the defines! FB21_UP & FB_21UP. 2nd variable is never defined anywhere and is just a typo. And this is not the full list of wrong directives.

[the-Arioch]

Line 128 was modified 2008-11-07 11:43 as a15fc97 with comments "unicode dataset" and "Delphi 2009"

should not be an issue

[the-Arioch]

ah, perhaps a typo indeed, thanks for spotting

[the-Arioch]

Line 144 is changed as 7d02967
on 2010-02-15 13:00
with comment "fix lockimeout"

i wonder...

[Alekcvp]

same fix, again:

+    {$IFNDEF **FB_21UP**}
 +      isc_tpb_shared,
 +      isc_tpb_protected,
 +      isc_tpb_exclusive,
 +    {$ENDIF}

[the-Arioch]

C:\Delphi\Libs\uib_git\source\uibase.pas [1]
C:\Delphi\Libs\uib_git\source\uibase.pas(1551): {$IFNDEF FB_21UP}
C:\Delphi\Libs\uib_git\source\uiblib.pas [2]
C:\Delphi\Libs\uib_git\source\uiblib.pas(144): {$IFNDEF FB_21UP}
C:\Delphi\Libs\uib_git\source\uiblib.pas(1779): {$IFNDEF FB_21UP}

Quick fix would be to fix those names, but then those options would be no more available if you compie against FB newer than 2.0

i would have to check into changes and API, to see if i can re-enable them without some weird side-effects

this topic is completely new to me

[Alekcvp]

but then those options would be no more available if you compie against FB newer than 2.0

They do not work with it anyway (in the current way).

[the-Arioch]

to read

theory: http://www.sql.ru/forum/actualutils.aspx?action=gotomsg&tid=451811&msg=4391275
2.1 practice: http://firebird.1100200.n4.nabble.com/2-1-td1283997.html

[Alekcvp]

Оттуда:

Там выходит что блокировки на таблицы ставятся в самый конец, уже после флагов
isc_tpb_nowait/isc_tpb_wait и isc_tpb_ignore_limbo, isc_tpb_autocommit, isc_tpb_no_auto_undo. А надо объявлять isc_tpb_lock_write и isc_tpb_protected до этих флагов ну и до wait/nowait

[the-Arioch]

Это обрывки, Когда будет время надо полноценно API Guide прочитать будет на эту тему