-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check command #7
Comments
thdk
changed the title
Idea after reading comment by @andidev in #3
Add a
Add check command
Dec 19, 2021
package-changed check
command that simply logs a warning that dependencies should be installed manually.
----
Now this is what we are trying to achieve:
If dependencies in package.json have changed. So the packagehash (based on package.json dependencies) is different. We know already that |
Yeah thats right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Idea after reading comment by @andidev in #3
Add a
package-changed check
command that simply logs a warning that dependencies should be installed manually.Now this is what we are trying to achieve:
npm run start
without running npm install since they are not aware that installed dependencies has changed. We want to make sure they run code with correct dependencies and install dependencies automatically.Solution: we add a script to run package install with options --lockfile, npm install and echo dependencies are updated
We want them to get informed that new dependencies needs to be installed. We don't want to install them because that could be annoying if they are not gonna run code.
Solution: we create a
post-checkout
githook where we runpackage-changed
with options --lockfile --skip-write-hash and echo warning dependencies needs to be install. We don't want to update hash since we want npm install to be triggered by 1).Solution: we create a
post-merge
githook where we run package install with options --lockfile, npm install and echo dependencies are updated.Originally posted by @andidev in #3 (comment)
The text was updated successfully, but these errors were encountered: