Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oidc-react and react-oidc #28

Open
simenandre opened this issue May 16, 2020 · 5 comments
Open

oidc-react and react-oidc #28

simenandre opened this issue May 16, 2020 · 5 comments

Comments

@simenandre
Copy link

simenandre commented May 16, 2020

Hello!

I'm currently maintaining oidc-react. Our projects utilize a lot of the same structure, maybe we should combine forces?

I think it is important to have an easy to get started oidc-client-based React package. Such as, honestly, both of our packages do. I don't need to put our company logo on anything, and I'll happily depreciate ours for yours (maybe with some changes). Maybe we should actually create an organization and be open for others to take a more active part in it?

I don't know, just wanted to get your opinion on it. :)

@thchia
Copy link
Owner

thchia commented Aug 4, 2020

Hello @cobraz - I am so sorry that I did not get back to you on this sooner. If this endeavour is still of interest to you I have no problem adding you as a collaborator on this project?

@simenandre
Copy link
Author

Maybe we can schedule a quick chat? I'll be happy to work on it 👍

@miguelzakharia
Copy link

Did you decide to combine the two repos?

@simenandre
Copy link
Author

We haven't been able to have a chat about it. Since this issue was created oidc-react has received much interest and a new co-maintainer, that I'd like to join this discussion, @ryancole :)

@ryancole
Copy link

What's the proposal? I'm not familiar. It seems we have two libraries focused on the same thing.

Personally, I chose oidc-react due to the hook nature of it. So perhaps that's some sort of common ground that could be made in terms of joining forces?

I'm not sure what the end goal here is, though.

@cobraz sounds like he's open to merging his repo with react-oidc. If that were the case, then hooks would be a thing I'd be looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants