Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename metrics #33

Open
loelkes opened this issue Nov 1, 2022 · 1 comment
Open

Rename metrics #33

loelkes opened this issue Nov 1, 2022 · 1 comment

Comments

@loelkes
Copy link
Contributor

loelkes commented Nov 1, 2022

I would like to rename and restructure the metrics so that the naming corresponds more to the OctoPrint namespace and follows some Prometheus best practices

  1. Add units where they are fixed.
  2. Follow Octoprint namespace. For example use keyword job instead of print for print jobs.
  3. Organize in categories printer, job, jobs and server

Examples:

  • octoprint_z_travel_print becomes octoprint_job_travel_z
  • octoprint_z_travel_total becomes octoprint_printer_travel_z
  • octoprint_done_prints becomes octoprint_jobs_done
  • octoprint_extrusion_print becomes octoprint_job_extrusion
  • octoprint_extrusion_total becomes octoprint_printer_extrusion
  • octoprint_infos becomes octoprint_server_info

No units to be set for distances and temperatures since Marlin (and others?) support Fahrenheit or Inches as well IIRC.

This would lead to version 3, since it is a breaking change. Please let me know if you @tg44 agree with the global direction and I'll prepare a PR.

@tg44
Copy link
Owner

tg44 commented Nov 1, 2022

I think its a good direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants