Use default registry to get automatic ProcessCollector #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Henderson <[email protected]>
tg44
reviewed
Feb 2, 2021
| @@ -17,8 +17,6 @@ class PrometheusExporterPlugin(octoprint.plugin.BlueprintPlugin, | |||
| octoprint.plugin.ProgressPlugin, | |||
| octoprint.plugin.EventHandlerPlugin): | |||
|
|
|||
| _registry = CollectorRegistry(auto_describe=True) | |||
There was a problem hiding this comment.
Actually it is needed based on this commit.
|
I close this without merge. The "custom" registry is needed, bcs when octoprint reloaded the plugin the whole thing broke. (We tried to register metrics what was already registered.) |
|
Ah, forgot about this 😓... no problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22
Removes the custom
CollectorRegistryin favour of using the default, which already has aProcessCollectorregistered on it. In particular, this exposeprocess_start_time_seconds(along with other useful metrics).Signed-off-by: Dave Henderson [email protected]