From 1ed92638c62704c769e6762b96c34d96b112e900 Mon Sep 17 00:00:00 2001 From: tfrommen Date: Sat, 26 Mar 2016 20:47:08 +0100 Subject: [PATCH] Write modular code. --- php/1-bad-practices/src/insane-complexity.php | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/php/1-bad-practices/src/insane-complexity.php b/php/1-bad-practices/src/insane-complexity.php index 8e02413..e8db60f 100644 --- a/php/1-bad-practices/src/insane-complexity.php +++ b/php/1-bad-practices/src/insane-complexity.php @@ -4,12 +4,16 @@ class Processor { public function process( $data ) { - // 16 lines full of different checks, a lot of if-else, ... + if ( ! $this->checker->check( $data ) ) { + return false; + } - // 23 lines full of data preparing, switch-case all over, ... + $data = $this->prepare( $data ); // 42 lines full of data processing... - // 8 lines full of post-processing, if-elseif-else again... + $this->post_processor->process( $data ); + + return true; } }