Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ch8 Finale task definition #25

Open
skaunov opened this issue May 28, 2023 · 1 comment
Open

Ch8 Finale task definition #25

skaunov opened this issue May 28, 2023 · 1 comment

Comments

@skaunov
Copy link
Contributor

skaunov commented May 28, 2023

Can we improve task definition so that limitations would be obvious from the start? It's my bad, I wasn't reading thorough enough, but staring long enough at Matcher::new signature output I decided that there's no way it could return None. Implemented it the way unmatched parenthesis go to RawText(_), and of course smashed into broken_matcher() test.

It's just a piece of feedback... Do you feel like that this detail deserve few words in the chapter?

@skaunov
Copy link
Contributor Author

skaunov commented Jul 30, 2023

Still not clear for example what Option should be return for ")(d|e)" string.

I finished a Gist to illustrate the path which lead me to some frustration. X) I started to suspect that it will end that way when new returned Some(..) for Option whenever. But here it is! If you (or others!) would give a review to the Gist on related or unrelated topics it would be really appreciated!

PS Praise to Ff and Gh which were saving draft of this comment from May!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant