Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

Full-screen image view is too sensitive to second (close) touch #1299

Open
andrewxhill opened this issue Aug 9, 2019 · 6 comments
Open

Full-screen image view is too sensitive to second (close) touch #1299

andrewxhill opened this issue Aug 9, 2019 · 6 comments
Labels
bug Something isn't working
Milestone

Comments

@andrewxhill
Copy link
Member

The full-screen view of a single shared image allows you to pan and pinch zoom an image. If you use one finger to pan the image, it will often just close it (since the view also has a 'tap to close' gesture). We need to detect longer presses and not close the view.

To create.

  • go to a shared group
  • click an image shared to the group
  • in the resulting full-screen image view, use a single finger to try and pan around the image

For me, the image will close instead of sticking to the pan.

@andrewxhill andrewxhill added the bug Something isn't working label Aug 9, 2019
@sanderpick
Copy link
Member

Based on other app UX (insta), user feedback, and just the fact that we shouldn't be guessing how to crop people's photos, we should plan to remove the square cropping in the feed. In which case, do we still want the full-screen view?

@asutula
Copy link
Member

asutula commented Aug 9, 2019

Tough call. We should discuss. There are many questions to answer, like are we going to stick with this instgram style feed? My own opinion, non-cropped portrait photos look really bad in the instgram style feed, they're soooo tall and take up almost all the visible area of the feed. Which is why instagram makes it impossible to post a full-height portrait photo (even their portrait mode requires you crop it to not be so tall).

@andrewxhill
Copy link
Member Author

full screen mode is even required for viewing one's own camera roll. the above problem could be fixed by adding different ways to close it or whatever, but full screen mode for a single image is required i think no matter

@sanderpick
Copy link
Member

Oh right, I forgot about the gird view. 👍

@undercase
Copy link
Contributor

We could remove the tap to close gesture and replace it with a "swipe away" gesture like on twitter's UI. I find that to be really convenient for larger screens, and it makes it easier to tell whether the user is trying to zoom or close the modal.

@andrewxhill
Copy link
Member Author

Cool, tagging this in Sprint 19 which starts next week. We can take a look if it makes sense.

@andrewxhill andrewxhill added this to the Sprint 19 milestone Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants