Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support puppeteer-core with pptr-testing-library/extend #48

Open
catdad opened this issue Sep 19, 2020 · 1 comment
Open

support puppeteer-core with pptr-testing-library/extend #48

catdad opened this issue Sep 19, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@catdad
Copy link

catdad commented Sep 19, 2020

Current, the extend tries to require and modify the puppeteer module. However, I've found several use cases for using puppeteer-core to already-installed browsers and not require users to install an unnecessary version of chromium. One such example is when testing Electron apps.

It would be great if the extend helper could work with puppeteer-core as well. Currently, it hard-codes looking for puppeteer specifically. When it is not available, it errors. I did a quick check and it seems to work just fine with puppeteer-core. Perhaps it can be added as an extra libPrefix to check?

@patrickhulce
Copy link
Collaborator

Thanks for filing @catdad! Yeah this SGTM 👍

@patrickhulce patrickhulce added the enhancement New feature or request label Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants