Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support testcontainers/ryuk as resource reaper #577

Open
Tracked by #563
DDtKey opened this issue Apr 22, 2024 · 2 comments
Open
Tracked by #563

Support testcontainers/ryuk as resource reaper #577

DDtKey opened this issue Apr 22, 2024 · 2 comments
Assignees
@DDtKey
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
0.24.0

Comments

@DDtKey
Copy link
Collaborator

DDtKey commented Apr 22, 2024 •
edited
Loading

Support https://hub.docker.com/r/testcontainers/ryuk as resource reaper, under separate feature ryuk
@DDtKey DDtKey mentioned this issue Apr 22, 2024
Closed
@mervyn-mccreight
Copy link
Contributor

We could also think about keeping watchdog for those who can't use ryuk, because of some constraints (e.g. using podman in rootless mode), or even make it the default if ryuk is not enabled. Or just provide both it behind features and the users can choose by themselves whether they want to use ryuk or watchdog.

WDYT?

@DDtKey
Copy link
Collaborator Author

DDtKey commented Apr 25, 2024

In general, I like the idea to keep both.

But I guess we need to extend watchdog to allow registration of networks (and named volumes?) to make it enabled by default. For now it works only for containers.

Anyway, I think ryuk should be implemented under separate feature ryuk, so we can keep watchdog and extend separately

@DDtKey DDtKey changed the title Support testcontainers/ryuk as resource reaper (deprecate watchdog) Support testcontainers/ryuk as resource reaper Apr 25, 2024
@DDtKey DDtKey added enhancement New feature or request help wanted Extra attention is needed labels May 30, 2024
Merged
This was referenced Jul 24, 2024
Open
Closed
@DDtKey DDtKey modified the milestones: 0.21.0, 0.22.0 Jul 24, 2024
@DDtKey DDtKey modified the milestones: 0.22.0, 0.23.0 Sep 4, 2024
@DDtKey DDtKey mentioned this issue Sep 6, 2024
Closed
@DDtKey DDtKey modified the milestones: 0.23.0, 0.24.0 Sep 25, 2024
@DDtKey DDtKey mentioned this issue Sep 30, 2024
Closed
@DDtKey DDtKey self-assigned this Sep 30, 2024
lloydmeta added a commit to lloydmeta/miniaturs that referenced this issue Oct 31, 2024
@lloydmeta
testcontainer refactoring
279c575 
Based on observation, localstack containers weren't being shutdown
properly.

It turns out static bindings don't get shut down, so we need
testcontainers/testcontainers-rs#707 (comment)
unti testcontainers/testcontainers-rs#577.

Signed-off-by: lloydmeta <[email protected]>
@lloydmeta lloydmeta mentioned this issue Oct 31, 2024
Merged
lloydmeta added a commit to lloydmeta/miniaturs that referenced this issue Oct 31, 2024
@lloydmeta
testcontainer refactoring (#4)
d244760 
Based on observation, localstack containers weren't being shutdown
properly.

It turns out static bindings don't get shut down, so we need
testcontainers/testcontainers-rs#707 (comment)
unti testcontainers/testcontainers-rs#577.

Signed-off-by: lloydmeta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DDtKey DDtKey

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
0.24.0
Development

No branches or pull requests
2 participants
@mervyn-mccreight @DDtKey