Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying images using sha256 digests #411

Open
boazberman opened this issue Oct 15, 2022 · 4 comments
Open

Support specifying images using sha256 digests #411

boazberman opened this issue Oct 15, 2022 · 4 comments

Comments

@boazberman
Copy link

You can run docker images by specifying the sha256 digest of the designated image instead of using a specific version.

Using sha256 is somewhat more secure as it pins the exact image, thus not allowing possible overriding of a tag by a malicious actor.

Usage can be something along:

impl Image for SomeImage {
    type Args = ();

    fn name(&self) -> String {
        "some name"
    }

    fn sha256(&self) -> String {
       "a826cb8a6a0023..."
    }
}
@boazberman
Copy link
Author

I intend on implementing it (as this can be useful for us), and it will be nice if the project can take part of the current hacktoberfest. Thanks!

@boazberman boazberman changed the title Support specifying images uaing sha256 digests Support specifying images using sha256 digests Oct 15, 2022
@thomaseizinger
Copy link
Collaborator

I am liking this idea. It would be well in line with the "Reliable" principle in our upcoming "Design principles" draft: #420

We would probably have to make it an Option.

I intend on implementing it (as this can be useful for us), and it will be nice if the project can take part of the current hacktoberfest. Thanks!

I am sorry for getting back to you too late for this to make any sense.

@boazberman
Copy link
Author

I am liking this idea. It would be well in line with the "Reliable" principle in our upcoming "Design principles" draft: #420

We would probably have to make it an Option.

I intend on implementing it (as this can be useful for us), and it will be nice if the project can take part of the current hacktoberfest. Thanks!

I am sorry for getting back to you too late for this to make any sense.

Cool, just now saw your comment, will try to implement that tomorrow!

@boazberman
Copy link
Author

I had created a PR: #446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants