Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker :Latest needs to point to latest version #90

Open
James-von-Detroit opened this issue Oct 6, 2023 · 9 comments
Open

Docker :Latest needs to point to latest version #90

James-von-Detroit opened this issue Oct 6, 2023 · 9 comments
Assignees
Labels
chore Changes that do not impact the existing functionality

Comments

@James-von-Detroit
Copy link

Just a heads up that the docker version testcontainers/ryuk:latest is pointing to an old version that hasn't been updated in three years.

https://hub.docker.com/layers/testcontainers/ryuk/latest/images/sha256-b2762871bff62df9bfcec62609da821803a575e06d74aa7ce1654ded208cc7c5?context=explore

@mdelapenya
Copy link
Member

Indeed, thanks for catching that. We can do this:

  1. directly update the latest tag with current 0.5.1
  2. automate the push to latest on each release of Ryuk

@mdelapenya mdelapenya self-assigned this Oct 9, 2023
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Oct 9, 2023
@James-von-Detroit
Copy link
Author

That would be great! Yes please do push the current version to the latest docker tag. I will be waiting for this and to test with my workflow. Thanks!

@bsideup
Copy link
Member

bsideup commented Oct 9, 2023

@mdelapenya actually, we intentionally stopped publish :latest, as we encourage everyone to use fixed versions. If anything, we should remove the outdated :latest tag :)

@kiview
Copy link
Member

kiview commented Oct 10, 2023

Just to get a bit more context, what is your use case to using Ryuk with a latest tag @James-von-Detroit?

@James-von-Detroit
Copy link
Author

James-von-Detroit commented Oct 10, 2023

@kiview Thank you for your question. I am using Ryuk with a latest tag because I want to pull the most recent version of the of the software. Using the latest tag ensures that I get the most updated features and fixes from the developers. I think it is a bad representation of this tool to have a latest tag that is outdated by three years and has many security vulnerabilities. It could mislead users who rely on the latest tag in their workflow and expect to get the most current version of Ryuk. Therefore, I suggest that the developers either update the latest tag regularly or remove it altogether to avoid confusion and potential risks.

You can go to this link https://hub.docker.com/r/testcontainers/ryuk/tags and see for yourself, sort by latest (Which I believe is the default view). And it shows the the latest tag and no updates to it. It's just good practice to align these things, it may not make sense to you with the latest tag, but I assure you people use it.

@kiview
Copy link
Member

kiview commented Oct 11, 2023

Thanks for the answer @James-von-Detroit, but please clarify, where do you use Ryuk with latest tag? Are you manually configuring Testcontainers to use Ryuk with latest tag? This is not recommended, since Testcontainers libraries versions rely on specific Ryuk versions. So before making the decision, I'd like to understand the actual use case.

I agree with the fact, that having an outdated latest tag makes no sense.

@James-von-Detroit
Copy link
Author

Note that even when I pull with "docker pull testcontainers/ryuk" and not using the latest tag. That it pulls that 3-year-old version.

@bsideup
Copy link
Member

bsideup commented Nov 4, 2023

@James-von-Detroit FYI Docker CLI will automatically append :latest if no tag is specified.

@gesellix
Copy link
Contributor

Maybe some use testcontainers/ryuk without using the other Testcontainers libraries.
An option is to intentionally break the :latest tag by pushing an invalid/failing image, so that users have to choose an explicit version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

No branches or pull requests

5 participants