Add data storage to task composer node info #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levi-Armstrong
force-pushed
the
feature/add-data-storage-to-node-info
branch
from
e9070b8
to
23d2a10
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #501 +/- ##
==========================================
- Coverage 84.73% 84.63% -0.10%
==========================================
Files 231 229 -2
Lines 15726 15656 -70
==========================================
- Hits 13325 13251 -74
- Misses 2401 2405 +4 |
Levi-Armstrong
merged commit 0776b5b
into
tesseract-robotics:master
13 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify things and avoid having to inherit from TaskComposerNodeInfo to store data which then required changes to tesseract_qt adding a data storage to the TaskComposerNodeInfo greatly simplifies things.