Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CompositeInstruction constructor order for improved ease of use #528

Open
marip8 opened this issue Nov 4, 2024 · 1 comment
Open

Comments

@marip8
Copy link
Contributor

marip8 commented Nov 4, 2024

Currently the constructor of the CompositeInstruction specifies a default value for the ordering type before a manipulator info. Most planners need the CompositeInstruction to specify a manipulator info, so it's painful to also be forced to specify the order type (which in almost all use-cases will be ORDERED). We should switch the order of these two default arguments such that the manipulator info object is first to make this easier to use

CompositeInstruction(std::string profile = DEFAULT_PROFILE_KEY,
CompositeInstructionOrder order = CompositeInstructionOrder::ORDERED,
tesseract_common::ManipulatorInfo manipulator_info = tesseract_common::ManipulatorInfo());

@Levi-Armstrong
Copy link
Contributor

That is fine with me. Mostly was just added to the end for backwards compatibility,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants