Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not usable as PWA #8

Open
PierreAndreis opened this issue Nov 17, 2019 · 2 comments
Open

Not usable as PWA #8

PierreAndreis opened this issue Nov 17, 2019 · 2 comments

Comments

@PierreAndreis
Copy link

PierreAndreis commented Nov 17, 2019

After adding to the home screen on my iPhone X iOS 13, I noticed that since I am not logged in, I am redirected to a landing page. The Hamburger menu at the top left is not clickable, which makes it unusable unless going through the flow of registering -> clicking on login.

Proposed solution
Make it so start_url is /dashboard in the manifest file: https://teslabout.com/manifest.json
This way, the starting URL, when the app is on the home screen, is the dashboard.

Also, consider using service workers for offline capabilities. Even though the app won't function, it would be nice to still be able to see the last cached data when offline.

@jjsoviet
Copy link
Collaborator

Thank you very much for the feedback!

I admittedly didn't consider the site to function as a PWA, so this is something that we should be offering during the wider release. Same for service workers; it would be useful to at least have the last known data available.

@joeypoon
Copy link
Member

We updated the start_url to /vehicles. We tried /dashboard but ran into a number of high effort state bugs so we decided on /vehicles. This also makes more sense for users with more than 1 vehicle. We've created a ticket for offline mode but this is backlogged for now while we deal with high value bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants