Skip to content
This repository has been archived by the owner on Nov 21, 2023. It is now read-only.

Main section of Bower config does not work correctly with Wiredep #177

Open
sarahquigley opened this issue Oct 15, 2016 · 4 comments
Open
Assignees

Comments

@sarahquigley
Copy link

Hi @terrymun ,

I use Wiredep for automatic injection of dependencies in many of my projects (technically I use grunt-wiredep). I'm using Fluidbox in one of my projects, and found that you have configured the main section of your bower.json file in a way that isn't compatible with Wiredep. (Wiredep did not pick up on Fluidbox's javascript files, and did not automatically inject them as dependencies.)

To fix this, I ended up overriding the bower.json main configuration for Fluidbox in my own bower.json file as follows:

 "overrides": {
    "fluidbox": {
      "main": [
        "dist/js/jquery.fluidbox.min.js",
        "dist/css/fluidbox.min.css"
      ]
    }
  }

I believe the above is the current expected convention for bower.json main paths.

While this overrides solution is working for me, it would be nice if this could be fixed Fluidbox's bower.json config to adhere to convention and so that anyone else who uses Wiredep for dependency injection will not encounter the same problem.

If you're interested in fixing this issue, I'd be willing to submit a PR.

Many thanks,

Sarah

@terrymun
Copy link
Owner

Hi @sarahquigley, sure, submit a PR if that's not too much trouble for you, that is very much appreciated. I have not worked with Wiredep before so I wouldn't know how to get bower.json configured properly for that purpose—but if this is going to help other people with integrating Fluidbox with Wiredep, why not? :)

@terrymun terrymun self-assigned this Oct 15, 2016
@sarahquigley
Copy link
Author

Thanks so being so quick to respond @terrymun! It would be my pleasure to put together a PR - I'll do so this weekend. It'll be a small change. I have plenty of projects using Wiredep to check the fix on. :)

Thanks again! If only all project maintainers were so responsive!

@terrymun
Copy link
Owner

Hi @sarahquigley, just checking on if you still intend to make a PR? If not, I will close this issue :)

@sarahquigley
Copy link
Author

Sorry! I totally forgot about this issue @terrymun. Let me fix it today. It's a really quick fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants