Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release.sh: Allow a callback script to update version in code #16

Open
nhooyr opened this issue Nov 30, 2022 · 2 comments
Open

release.sh: Allow a callback script to update version in code #16

nhooyr opened this issue Nov 30, 2022 · 2 comments

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Nov 30, 2022

Maybe instead of executing release.sh, we source it instead in the in repo scripts.
@nhooyr
Copy link
Contributor Author

nhooyr commented Nov 30, 2022

  • Will also need to update tala's build process to do the same.

Perhaps just make release.sh automatically updates any lib/version/version.go? Would need to keep -HEAD suffix though unless I want the git tag to include an extra commit removing the suffix. this commit not being merged into master.

This was referenced Nov 30, 2022
Merged
Closed
@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 1, 2022

Maybe we just always update lib/version/version.go if it exists. Then no custom callback needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nhooyr