Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Completely filled crude soul crystal cannot supply arrows for soul steel bow #58

Open
Caointeach opened this issue Jan 16, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Caointeach
Copy link

Bug Description

Crude soul crystals work with soul steel bows until the crystal is completely full, at which point the bow can no longer be drawn and fired.

I suspected this was because getCrudeSoulCrystal checks canCrystalAcceptSoul. On the assumption that mustContainSouls is only true when souls are being expended, I tried the following change, and it seems to work.

$ diff SoulUtils.java.bak SoulUtils.java
181c181
<             if (!SoulUtils.canCrystalAcceptSoul(currentItem, null)) continue;
---
>             if (!SoulUtils.canCrystalAcceptSoul(currentItem, null) && !mustContainSouls) continue;

Regular soul crystals don't have this problem as getSoulCrystal skips canCrystalAcceptSoul due to the victim argument being null.

How to Reproduce?

  1. Obtain a crude soul crystal and soul steel bow in survival mode.
  2. Kill enough mobs that the crystal is full.
  3. While having no other soul crystals in inventory, attempt to nock an arrow with bow.

Expected Behavior

No response

Version

2.2.3

Mod Loader Version

1.19.2

Mod Loader

Forge

Logs or additional context

No response

@Caointeach Caointeach added the bug Something isn't working label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant