Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add longer descriptions to impls in flags #1595

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

keckler
Copy link
Member

@keckler keckler commented Jan 22, 2024

What is the change?

Just adds descriptions to the implementation tags in the flags module.

Why is the change being made?

Quality.


Checklist

  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • If any requirements were affected, mention it in the release notes.
  • The dependencies are still up-to-date in pyproject.toml.

@john-science john-science added the documentation Improvements or additions to documentation label Jan 23, 2024
@john-science
Copy link
Member

The unit tests for this PR are throwing the error:

  File "/home/runner/work/armi/armi/armi/reactor/flags.py", line 253, in fromStringIgnoreErrors
    return __fromStringGeneral(cls, typeSpec, updateMethodIgnoreErrors)
NameError: name '_Flags__fromStringGeneral' is not defined

armi/reactor/flags.py Outdated Show resolved Hide resolved
Copy link

@linconnor linconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added impls info looks good.

armi/reactor/flags.py Outdated Show resolved Hide resolved
armi/reactor/flags.py Outdated Show resolved Hide resolved
@john-science john-science merged commit 8ba0aaf into terrapower:main Jan 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants