Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding implementation details to tags in globalFlux #1588

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

zachmprince
Copy link
Contributor

@zachmprince zachmprince commented Jan 19, 2024

What is the change?

This is adding details of the implementation in the .. impl:: tags within globalFlux. Most of them are adding paragraphs. A couple of them I simply put the Notes section in the doctring under the tag to avoid duplicate information.

Why is the change being made?

This is part of on-going QA work.


Checklist

  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • If any requirements were affected, mention it in the release notes.
  • The dependencies are still up-to-date in pyproject.toml.

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2024

CLA assistant check
All committers have signed the CLA.

@john-science john-science added the documentation Improvements or additions to documentation label Jan 19, 2024
@john-science john-science self-requested a review January 22, 2024 20:54
Copy link
Member

@john-science john-science left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am "Approving" in Tian's place, as GH doesn't seem to recognize her account?

TBD. We'll fix that.

@john-science john-science merged commit 8bfaea6 into terrapower:main Jan 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants