Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Parent tests/impls/reqs #1565

Merged
merged 8 commits into from
Jan 2, 2024
Merged

Conversation

Ashlita6
Copy link
Contributor

@Ashlita6 Ashlita6 commented Dec 22, 2023

What is the change?

This PR is to combine the children and parent requirements/implementations and tests into one.

Why is the change being made?

Parent requirements are presenting downstream challenges for document review and they aren't needed because they are satisfied by the children.


Checklist

  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • If any requirements were affected, mention it in the release notes.
  • The dependencies are still up-to-date in pyproject.toml.

Copy link
Member

@keckler keckler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These impls/tests look good with the corresponding PR on our internal app.

Thanks @Ashlita6 and @opotowsky !

@john-science john-science added the documentation Improvements or additions to documentation label Jan 2, 2024
@opotowsky opotowsky merged commit 24e36fe into terrapower:main Jan 2, 2024
11 checks passed
@john-science john-science deleted the doc_Armi_Parents branch January 2, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants