Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More converters testing updates #1555

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

albeanth
Copy link
Member

What is the change?

Some more updates to the converters as part of a review for requirements.

Why is the change being made?

Reviewers are people too.


Checklist

  • The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
  • The documentation is still up-to-date in the doc folder.
  • No requirements were altered.
  • The dependencies are still up-to-date in pyproject.toml.

@albeanth albeanth added the testing Related to tests label Dec 14, 2023
@albeanth
Copy link
Member Author

@Ashlita6 just fyi.

@Ashlita6
Copy link
Contributor

I tried to add my review. But it still shows a review required? Not sure what is happening there.

@john-science john-science self-requested a review December 15, 2023 17:00
Copy link
Member

@john-science john-science left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve because Ashley approved. Approval by proxy.

@john-science john-science merged commit b6f1053 into terrapower:main Dec 15, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants