Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further issues found with the EOL being written to the Database #1960

Open
john-science opened this issue Oct 18, 2024 · 1 comment
Open
Labels
bug Something is wrong: Highest Priority

Comments

@john-science
Copy link
Member

john-science commented Oct 18, 2024

@albeanth and I identified two places where the ARMI codebase does not support the new EOL time point being written to the database (added in PR 1090):

  1. Database3.genTimeSteps():

def genTimeSteps(self) -> Generator[Tuple[int, int], None, None]:

Returns (cycle, node), but if the EOL is present in the DB, it just returns the last time node twice.

  1. Database3.load() takes in cycle and node as integers, thus not allowing us to load an EOL timestep:

@john-science john-science added the bug Something is wrong: Highest Priority label Oct 18, 2024
@john-science john-science self-assigned this Oct 18, 2024
@albeanth
Copy link
Member

Cross-referencing #1090 since it's related.

@john-science john-science removed their assignment Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong: Highest Priority
Projects
None yet
Development

No branches or pull requests

2 participants