Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a method for determining center locations of children on a block #1956

Open
drewj-tp opened this issue Oct 15, 2024 · 1 comment
Open
Labels
feature request Smaller user request

Comments

@drewj-tp
Copy link
Contributor

I know this isn't part of your design, but maybe this method could take an optional flag parameter that defaults to Flags.CLAD. That way, if in the future someone wants to use some other flag to identify what they want to define as a "pin".

This request is scope creep, but it seems like a one-line change and a single unit test to make this more extensible in ways that you have convinced me are important.

Thoughts?

Originally posted by @john-science in #1943 (comment)

@john-science john-science added the feature request Smaller user request label Oct 15, 2024
@john-science
Copy link
Member

This was originally a comment on Block.getPinLocations(), to just add a input flag to make this method more flexible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Smaller user request
Projects
None yet
Development

No branches or pull requests

2 participants