You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I know this isn't part of your design, but maybe this method could take an optional flag parameter that defaults to Flags.CLAD. That way, if in the future someone wants to use some other flag to identify what they want to define as a "pin".
This request is scope creep, but it seems like a one-line change and a single unit test to make this more extensible in ways that you have convinced me are important.
I know this isn't part of your design, but maybe this method could take an optional
flag
parameter that defaults toFlags.CLAD
. That way, if in the future someone wants to use some other flag to identify what they want to define as a "pin".This request is scope creep, but it seems like a one-line change and a single unit test to make this more extensible in ways that you have convinced me are important.
Thoughts?
Originally posted by @john-science in #1943 (comment)
The text was updated successfully, but these errors were encountered: