Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port @terraformer/wkt #3

Closed
jgravois opened this issue Dec 31, 2018 · 7 comments · Fixed by #17
Closed

port @terraformer/wkt #3

jgravois opened this issue Dec 31, 2018 · 7 comments · Fixed by #17
Assignees

Comments

@jgravois
Copy link
Member

No description provided.

@jgravois
Copy link
Member Author

jgravois commented Jan 6, 2019

ok @JerrySievert, i'm done porting the arcgis parser and spatial predicates. if you have any trouble getting acclimated in the monorepo, please holler.

@JerrySievert
Copy link
Member

I'm slowly on it :)

@jgravois
Copy link
Member Author

jgravois commented Jan 8, 2019

no rush. the bone stock JSDoc actually ain't bad.

@jgravois
Copy link
Member Author

jgravois commented Apr 4, 2019

i was bored last night so i decided to just knock this out.

#17 still uses jison, but it points at a fork that introduces a tiny feature to help us ship both a ES Module and a UMD.

@JerrySievert
Copy link
Member

Awesome. I kept meaning to get reengaged but things kept taking priority. And that’s the same jison fork I had planned on using. I’ll try to take a look either tonight at the airport if time or when I make it home.

@jgravois
Copy link
Member Author

jgravois commented Apr 4, 2019

I kept meaning to get reengaged but things kept taking priority.

no rush, but a sanity check would be most appreciated Señor @JerrySievert.

i really enjoyed your JSON v JSONB blog post a couple weeks back!

@JerrySievert
Copy link
Member

Sanity check is the least of what I can do :)

And thanks! That came out of a perplexing email chain I received via plv8. If you’re interested in what came out of it, go take a look at the recent changes on plv8/plv8 3.0alpha branch (sorry, no link on phone). Ended up switching to a direct jsonb to v8::object conversion and changed some memory contexts around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants