Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to support multiple hostnames and DNS zones #136

Closed
rapides opened this issue Aug 18, 2023 · 27 comments · Fixed by #149
Closed

Ability to support multiple hostnames and DNS zones #136

rapides opened this issue Aug 18, 2023 · 27 comments · Fixed by #149

Comments

@rapides
Copy link

rapides commented Aug 18, 2023

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

  • Yes ✅: please list the AWS provider version which introduced this functionality

Is your request related to a problem? Please describe.

I cannot select more zone_id when I want to support more than one DNS name with totally different hostnames. In order to create CloudFront distribution that uses 2 totally different domains at the same time (example: example.com and example.co) and I need to use a single SSL certificate that whitelists 2 different hostnames. In such cases, each domain has to have a separate DNS zone.

Describe the solution you'd like.

Ability to enter domains and zones together via a single variable, so you can easily distinguish when you need to create DNS records in separate DNS zones.

Describe alternatives you've considered.

N/A

Additional context

@amontalban
Copy link
Contributor

We are having the same need, would be great to genera an ACM certificate with multiple domains so we don't have to create multiple CloudFront distributions.

@amontalban
Copy link
Contributor

@rapides can you try #137 and see if that works for you? Thanks!

@github-actions
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Oct 14, 2023
@phuhl
Copy link

phuhl commented Oct 16, 2023

I have the same issue

@github-actions github-actions bot removed the stale label Oct 17, 2023
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 17, 2023
@phuhl
Copy link

phuhl commented Nov 17, 2023

Issue still perists

@github-actions github-actions bot removed the stale label Nov 18, 2023
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 18, 2023
@phuhl
Copy link

phuhl commented Dec 18, 2023

Issue still perists

@github-actions github-actions bot removed the stale label Dec 19, 2023
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Jan 18, 2024
@phuhl
Copy link

phuhl commented Jan 23, 2024

Issue still perists

@github-actions github-actions bot removed the stale label Jan 24, 2024
@antonbabenko
Copy link
Member

#137 (review) - my review is still relevant and someone can take it further and work on improvements.

@alemarmed
Copy link
Contributor

Hi @amontalban, do you intend to resume #137? Otherwise I think I could make requested changes.

Copy link

github-actions bot commented Mar 4, 2024

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 4, 2024
@phuhl
Copy link

phuhl commented Mar 5, 2024

Issue still perists, I don't know the code in here at all, so I am not sure, it makes sense for me to work on this, but @amontalban maybe you could create a new PR based on #137?

Copy link

github-actions bot commented Apr 5, 2024

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Apr 5, 2024
@phuhl
Copy link

phuhl commented Apr 5, 2024

Issue still persists, waiting for #149

@github-actions github-actions bot removed the stale label Apr 6, 2024
Copy link

github-actions bot commented May 6, 2024

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label May 6, 2024
@phuhl
Copy link

phuhl commented May 6, 2024

Issue still persists, waiting for #149

@github-actions github-actions bot removed the stale label May 7, 2024
Copy link

github-actions bot commented Jun 6, 2024

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Jun 6, 2024
@phuhl
Copy link

phuhl commented Jun 10, 2024

Issue still persists, waiting for #149

@github-actions github-actions bot removed the stale label Jun 11, 2024
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Jul 11, 2024
@phuhl
Copy link

phuhl commented Jul 11, 2024

Issue still persists, waiting for #149

@github-actions github-actions bot removed the stale label Jul 12, 2024
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Aug 11, 2024
@phuhl
Copy link

phuhl commented Aug 12, 2024

Issue still persists, waiting for #149

@antonbabenko
Copy link
Member

@phuhl it's your turn to check it out and open an issue if you see something wrong. I'm sorry it took so long to get this one reviewed and merged.

@phuhl
Copy link

phuhl commented Aug 14, 2024

Thank you for putting the work in :)

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants