Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special icon for pages with no fallback language not shown #253

Closed
minstyle opened this issue Jul 24, 2024 · 4 comments · Fixed by #254
Closed

Special icon for pages with no fallback language not shown #253

minstyle opened this issue Jul 24, 2024 · 4 comments · Fixed by #254

Comments

@minstyle
Copy link

Contao 5.3.11
PHP 8.3.9
terminal42/contao-changelanguage 3.7.4
Languages: DE + EN

If no fallback language is defined for a page, this is no longer indicated by a special icon in the Contao page structure. Therefore, it is currently not visible for which pages a fallback language is defined and for which not.

grafik

No fallback language defined:

grafik

@minstyle minstyle changed the title No icon for assigning main language for pages not shown Special icon for pages with no fallback language not shown Jul 24, 2024
@fritzmg
Copy link
Contributor

fritzmg commented Jul 24, 2024

The icon is only shown in the non-fallback trees. From your screenshots it is not clear whether that is the case for you or not (as English is typically the main/fallback language).

@minstyle
Copy link
Author

minstyle commented Jul 24, 2024

German page tree is definded as fallback and the main language of the website:

grafik

The english page tree ist not defined as fallback:

grafik

@fritzmg
Copy link
Contributor

fritzmg commented Jul 24, 2024

You should set English as the fallback, not German btw. ;) (otherwise non-German speaking visitors will see the German website, instead of the English one).

Anyways, I can reproduce the issue in 3.7.4.

@aschempp
Copy link
Member

You should set English as the fallback, not German btw. ;) (otherwise non-German speaking visitors will see the German website, instead of the English one).

@fritzmg that is totally unrelated to this issue and not necessary true for all websites. It really depends on your client and shouldn't be stated as a generic fact.

Seems like the issue does exist and #254 should fix it. Closing this for the pull request then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants