Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify interface for get_register_address #63

Open
vtangTT opened this issue Sep 17, 2024 · 0 comments
Open

Clarify interface for get_register_address #63

vtangTT opened this issue Sep 17, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request P2 Minor issues

Comments

@vtangTT
Copy link
Contributor

vtangTT commented Sep 17, 2024

As per comments from @joelsmithTT on #40

I think the 'register' part of get_register_address is a bit misleading here.. if I understand the code correctly, it can end up writing to a register exposed in a PCIe BAR, or write through an inbound TLB window (to what might be either memory or a register).

It is probably worth making a distinction between these scenarios at the interface level.

@vtangTT vtangTT added the enhancement New feature or request label Sep 17, 2024
@vtangTT vtangTT self-assigned this Sep 17, 2024
This was referenced Sep 17, 2024
@pjanevskiTT pjanevskiTT added the P2 Minor issues label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Minor issues
Projects
None yet
Development

No branches or pull requests

2 participants