Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal-build.md docker build syntax error #1191

Open
johnwalicki opened this issue Nov 7, 2024 · 1 comment · May be fixed by #1192
Open

internal-build.md docker build syntax error #1191

johnwalicki opened this issue Nov 7, 2024 · 1 comment · May be fixed by #1192
Assignees
@staylorTT
Labels
community

Comments

@johnwalicki
Copy link

The Internal Build Notes / IRD documentation at https://github.com/tenstorrent/tt-mlir/blob/main/docs/src/internal-build.md has a docker build syntax error. The -build-args flag should be --build-arg

I also noticed several spelling/grammar/markdown lint errors.

For your consideration, I will submit a PR to fix these minor issues.
johnwalicki added a commit to johnwalicki/tt-mlir that referenced this issue Nov 7, 2024
@johnwalicki
Fix docker build flag (tenstorrent#1191)
4435574 
Signed-off-by: John Walicki <[email protected]>
@johnwalicki johnwalicki linked a pull request Nov 7, 2024 that will close this issue
Open
@staylorTT
Copy link
Contributor

Thank you for the feedback. We definitely welcome and will review any PR.

@staylorTT staylorTT self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staylorTT staylorTT

Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix docker build flag (#1191) johnwalicki/tt-mlir
2 participants
@johnwalicki @staylorTT