[Bug Report] Use after move in run_operation.cpp #15073
Comments
|
Thank you! On it! |
|
Thanks @ayerofieiev-tt ! <3 |
|
Fixing this specific issue. Then we should enable the clang-tidy check and fixing any issue that it surfaces. Line 28 in 008c50a |
ayerofieiev-tt
added a commit
that referenced
this issue
Nov 15, 2024
1 task
|
Thanks for the quick patch! There shouldn't be any more as of now. I ran clang-analyzer over the entire codebase and this is the only use after move. |
ayerofieiev-tt
added a commit
that referenced
this issue
Nov 15, 2024
### Ticket #15073 ### Problem description Recent changes cause a use after move ### What's changed Fixing the issue. @blozano-tt @afuller-TT will help to enable a corresponding clang-tidy check https://github.com/tenstorrent/tt-metal/blob/008c50a744ab398526f12992f9f4902283f9215a/.clang-tidy#L28 ### Checklist - [x] [Post commit CI](https://github.com/tenstorrent/tt-metal/actions/runs/11850149066)
|
Close as patch merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
This is a bug discovered by clang-analyzer following a long discussion on discord. In
run_operation.cpp. Theoperationobject is moved before callingoperation.compute_output_shapes(). Causing a UB. I am not sure weather if it is causing any actual trouble now, but probably worth fixing.Due to the nature of non-const functions. I am unable to fix myself as I lack the low level understanding of how this part of program works.
To Reproduce
In
ttnn/cpp/ttnn/run_operation.cpp, line 372-374 and 437-437Expected behavior
Should not trigger UB.
Screenshots
If applicable, add screenshots to help explain your problem.
Please complete the following environment information:
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: